[PATCH] D52662: [libc++] Make sure we can build libc++ with -fvisibility=hidden

[Eric Fiselier via Phabricator]

EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.

If we're adding a new "Visibility" macro, then the VisibilityMacros.rst doc should be updated to include it.

Otherwise, I don't see any other problems in this patch. I'll leave it to other reviewers.



================
Comment at: libcxx/include/__debug:77
 ///    fails.
-extern _LIBCPP_EXTERN_VIS __libcpp_debug_function_type __libcpp_debug_function;
 
----------------
Is this the only usage of `_LIBCPP_EXTERN_VIS`?

If so, please go ahead and purge all definitions of the macro as well as it's documentation.


Repository:
  rCXX libc++

https://reviews.llvm.org/D52662