[PATCH] D53127: Fix declaration of _URC_FATAL_PHASE1_ERROR in libc++abi when compiled with gcc (follow-up of D42242)

[Marshall Clow via Phabricator]

mclow.lists added inline comments.


================
Comment at: src/cxa_exception.hpp:31
 
+#if defined(__arm__) && defined(__GNUC__)
+// missing values from _Unwind_Reason_Code enum
----------------
mgorny wrote:
> `__GNUC__` also defined when using clang, so the definitions from clang will be overwritten by this.
Is there an identifier that we can check to say "we're using the GNU unwind library"? Maybe `__ARM_EABI_UNWINDER__`?


Repository:
  rCXXA libc++abi

https://reviews.llvm.org/D53127