[PATCH] D53127: Fix declaration of _URC_FATAL_PHASE1_ERROR in libc++abi when compiled with gcc (follow-up of D42242)

Marshall Clow via Phabricator reviews at reviews.llvm.org
Thu Oct 11 08:52:50 PDT 2018


mclow.lists added a comment.

In https://reviews.llvm.org/D53127#1261618, @stefson wrote:

> Well, if `__defined(___GNUC___)` does target both gcc and clang, it doesn't make much sense in the first place. How can I state the `defined` marcro only for gcc?


In libc++'s `<__config>` header, we check for clang first (using `#if defined(__clang__)`) and then if that fails, check for GCC (using `#elif defined(__GNUC__)`)


Repository:
  rCXXA libc++abi

https://reviews.llvm.org/D53127





More information about the libcxx-commits mailing list