[PATCH] D53028: [libcxxabi] Allow building with sanitizers enabled

Eric Fiselier via Phabricator reviews at reviews.llvm.org
Wed Oct 10 11:45:06 PDT 2018


EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

@ldionne This looks fine to me, but I don't love the duplication.

I think this patch gives yet another reason why libc++ and libc++abi should live in the same repo.



================
Comment at: libcxxabi/src/CMakeLists.txt:116
+    else()
+      message(WARNING "LLVM_USE_SANITIZER=${LLVM_USE_SANITIZER} is not supported on OS X")
+    endif()
----------------
mclow.lists wrote:
> Is this just a Mac OS X feature, then?
We only need this configuration on Mac OS X because the Clang driver on other platforms links these libraries for us.


Repository:
  rCXX libc++

https://reviews.llvm.org/D53028





More information about the libcxx-commits mailing list