[libcxxabi] r347670 - [Demangle] remove itaniumFindTypesInMangledName

Pavel Labath pavel at labath.sk
Tue Nov 27 08:11:24 PST 2018


Author: labath
Date: Tue Nov 27 08:11:24 2018
New Revision: 347670

URL: http://llvm.org/viewvc/llvm-project?rev=347670&view=rev
Log:
[Demangle] remove itaniumFindTypesInMangledName

Summary:
This (very specialized) function was added to enable an LLDB use case.
Now that a more generic interface (overriding of parser functions -
D52992)  is available, and LLDB has been converted to use that (D54074),
the function is unused and can be removed.

Reviewers: erik.pilkington, sgraenitz, rsmith

Subscribers: mgorny, hiraditya, christof, libcxx-commits, llvm-commits

Differential Revision: https://reviews.llvm.org/D54893

Modified:
    libcxxabi/trunk/src/demangle/ItaniumDemangle.h

Modified: libcxxabi/trunk/src/demangle/ItaniumDemangle.h
URL: http://llvm.org/viewvc/llvm-project/libcxxabi/trunk/src/demangle/ItaniumDemangle.h?rev=347670&r1=347669&r2=347670&view=diff
==============================================================================
--- libcxxabi/trunk/src/demangle/ItaniumDemangle.h (original)
+++ libcxxabi/trunk/src/demangle/ItaniumDemangle.h Tue Nov 27 08:11:24 2018
@@ -2162,9 +2162,6 @@ template <typename Derived, typename All
   // conversion operator's type, and are resolved in the enclosing <encoding>.
   PODSmallVector<ForwardTemplateReference *, 4> ForwardTemplateRefs;
 
-  void (*TypeCallback)(void *, const char *) = nullptr;
-  void *TypeCallbackContext = nullptr;
-
   bool TryToParseTemplateArgs = true;
   bool PermitForwardTemplateReferences = false;
   bool ParsingLambdaParams = false;
@@ -3458,9 +3455,6 @@ template <typename Derived, typename All
 Node *AbstractManglingParser<Derived, Alloc>::parseType() {
   Node *Result = nullptr;
 
-  if (TypeCallback != nullptr)
-    TypeCallback(TypeCallbackContext, First);
-
   switch (look()) {
   //             ::= <qualified-type>
   case 'r':




More information about the libcxx-commits mailing list