[PATCH] D54838: [libcxx] Fix order checking in unordered_multimap tests.
Andrey Maksimov via Phabricator
reviews at reviews.llvm.org
Tue Nov 27 07:42:24 PST 2018
amakc11 updated this revision to Diff 175480.
amakc11 added a comment.
Initializer-list construction replaced with `insert()` throughout the tests.
In D54838#1308594 <https://reviews.llvm.org/D54838#1308594>, @ldionne wrote:
> Could you please keep the order-dependent tests in a suitably-named file under `test/libcxx/<...>` instead of `test/std/<...>`? Tests under `test/libcxx/` are libc++-specific.
I would suggest someone from libc++ test suite developers/maintainers team to do this, if it is necessary for them, before the patch is applied to `test/std/<...>` tests. I'm not a member of this team, but just yet another external user of `test/std/<...>` tests. So, I'd like to avoid intervening into another expert team's job by trying to solve their internal tasks having no sufficient expertize to do this.
CHANGES SINCE LAST ACTION
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 24576 bytes
Desc: not available
More information about the libcxx-commits