[libcxx] r347475 - [libcxx] Reintroduce UNSUPPORTED annotation for strstreambuf overflow test

Louis Dionne ldionne at apple.com
Thu Nov 22 09:43:23 PST 2018


Author: ldionne
Date: Thu Nov 22 09:43:22 2018
New Revision: 347475

URL: http://llvm.org/viewvc/llvm-project?rev=347475&view=rev
Log:
[libcxx] Reintroduce UNSUPPORTED annotation for strstreambuf overflow test

This is a revert of r347421, except I'm using the with_system_cxx_lib
lit feature instead of availability to mark the test as unsupported
(because the problem is a bug in the dylib itself). In r347421, I said
I wasn't able to reproduce the issue and that's why I was removing it:
this was because I ran lit slightly wrong. The problem mentioned really
exists.

Modified:
    libcxx/trunk/test/std/depr/depr.str.strstreams/depr.strstreambuf/depr.strstreambuf.members/overflow.pass.cpp

Modified: libcxx/trunk/test/std/depr/depr.str.strstreams/depr.strstreambuf/depr.strstreambuf.members/overflow.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/depr/depr.str.strstreams/depr.strstreambuf/depr.strstreambuf.members/overflow.pass.cpp?rev=347475&r1=347474&r2=347475&view=diff
==============================================================================
--- libcxx/trunk/test/std/depr/depr.str.strstreams/depr.strstreambuf/depr.strstreambuf.members/overflow.pass.cpp (original)
+++ libcxx/trunk/test/std/depr/depr.str.strstreams/depr.strstreambuf/depr.strstreambuf.members/overflow.pass.cpp Thu Nov 22 09:43:22 2018
@@ -13,6 +13,10 @@
 
 // int overflow(int c);
 
+// There was an overflow in the dylib on older macOS versions
+// UNSUPPORTED: with_system_cxx_lib=macosx10.8
+// UNSUPPORTED: with_system_cxx_lib=macosx10.7
+
 #include <iostream>
 #include <string>
 #include <strstream>




More information about the libcxx-commits mailing list