[libcxx] r347360 - A couple of tests were broken when clang implemented the compiler parts of P0482 (support for char8_t). Comment out those bits until we implement the corresponding bits in libc++

Marshall Clow mclow.lists at gmail.com
Tue Nov 20 14:55:41 PST 2018


Author: marshall
Date: Tue Nov 20 14:55:40 2018
New Revision: 347360

URL: http://llvm.org/viewvc/llvm-project?rev=347360&view=rev
Log:
A couple of tests were broken when clang implemented the compiler parts of P0482 (support for char8_t). Comment out those bits until we implement the corresponding bits in libc++

Modified:
    libcxx/trunk/test/std/strings/basic.string.literals/literal.pass.cpp
    libcxx/trunk/test/std/strings/string.view/string_view.literals/literal.pass.cpp

Modified: libcxx/trunk/test/std/strings/basic.string.literals/literal.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/strings/basic.string.literals/literal.pass.cpp?rev=347360&r1=347359&r2=347360&view=diff
==============================================================================
--- libcxx/trunk/test/std/strings/basic.string.literals/literal.pass.cpp (original)
+++ libcxx/trunk/test/std/strings/basic.string.literals/literal.pass.cpp Tue Nov 20 14:55:40 2018
@@ -13,12 +13,17 @@
 #include <string>
 #include <cassert>
 
+#include "test_macros.h"
+
 int main()
 {
     using namespace std::literals::string_literals;
 
     static_assert ( std::is_same<decltype(   "Hi"s), std::string>::value, "" );
+//	This is changed by P0482 to return a std::u8string
+#if TEST_STD_VER <= 17
     static_assert ( std::is_same<decltype( u8"Hi"s), std::string>::value, "" );
+#endif
     static_assert ( std::is_same<decltype(  L"Hi"s), std::wstring>::value, "" );
     static_assert ( std::is_same<decltype(  u"Hi"s), std::u16string>::value, "" );
     static_assert ( std::is_same<decltype(  U"Hi"s), std::u32string>::value, "" );
@@ -29,19 +34,28 @@ int main()
     std::u32string Ufoo;
 
     foo  =   ""s;     assert( foo.size() == 0);
+//	This is changed by P0482 to return a std::u8string
+#if TEST_STD_VER <= 17
     foo  = u8""s;     assert( foo.size() == 0);
+#endif
     Lfoo =  L""s;     assert(Lfoo.size() == 0);
     ufoo =  u""s;     assert(ufoo.size() == 0);
     Ufoo =  U""s;     assert(Ufoo.size() == 0);
 
     foo  =   " "s;     assert( foo.size() == 1);
+//	This is changed by P0482 to return a std::u8string
+#if TEST_STD_VER <= 17
     foo  = u8" "s;     assert( foo.size() == 1);
+#endif
     Lfoo =  L" "s;     assert(Lfoo.size() == 1);
     ufoo =  u" "s;     assert(ufoo.size() == 1);
     Ufoo =  U" "s;     assert(Ufoo.size() == 1);
 
     foo  =   "ABC"s;     assert( foo ==   "ABC");   assert( foo == std::string   (  "ABC"));
+//	This is changed by P0482 to return a std::u8string
+#if TEST_STD_VER <= 17
     foo  = u8"ABC"s;     assert( foo == u8"ABC");   assert( foo == std::string   (u8"ABC"));
+#endif
     Lfoo =  L"ABC"s;     assert(Lfoo ==  L"ABC");   assert(Lfoo == std::wstring  ( L"ABC"));
     ufoo =  u"ABC"s;     assert(ufoo ==  u"ABC");   assert(ufoo == std::u16string( u"ABC"));
     Ufoo =  U"ABC"s;     assert(Ufoo ==  U"ABC");   assert(Ufoo == std::u32string( U"ABC"));

Modified: libcxx/trunk/test/std/strings/string.view/string_view.literals/literal.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/strings/string.view/string_view.literals/literal.pass.cpp?rev=347360&r1=347359&r2=347360&view=diff
==============================================================================
--- libcxx/trunk/test/std/strings/string.view/string_view.literals/literal.pass.cpp (original)
+++ libcxx/trunk/test/std/strings/string.view/string_view.literals/literal.pass.cpp Tue Nov 20 14:55:40 2018
@@ -16,12 +16,17 @@
 #include <string_view>
 #include <cassert>
 
+#include "test_macros.h"
+
 int main()
 {
     using namespace std::literals::string_view_literals;
 
     static_assert ( std::is_same<decltype(   "Hi"sv), std::string_view>::value, "" );
+//	This is changed by P0482 to return a std::u8string - re-enable when we implement that.
+#if TEST_STD_VER <= 17
     static_assert ( std::is_same<decltype( u8"Hi"sv), std::string_view>::value, "" );
+#endif
     static_assert ( std::is_same<decltype(  L"Hi"sv), std::wstring_view>::value, "" );
     static_assert ( std::is_same<decltype(  u"Hi"sv), std::u16string_view>::value, "" );
     static_assert ( std::is_same<decltype(  U"Hi"sv), std::u32string_view>::value, "" );
@@ -32,31 +37,46 @@ int main()
     std::u32string_view Ufoo;
 
     foo  =   ""sv;     assert( foo.size() == 0);
+//	This is changed by P0482 to return a std::u8string - re-enable when we implement that.
+#if TEST_STD_VER <= 17
     foo  = u8""sv;     assert( foo.size() == 0);
+#endif
     Lfoo =  L""sv;     assert(Lfoo.size() == 0);
     ufoo =  u""sv;     assert(ufoo.size() == 0);
     Ufoo =  U""sv;     assert(Ufoo.size() == 0);
 
     foo  =   " "sv;     assert( foo.size() == 1);
+//	This is changed by P0482 to return a std::u8string - re-enable when we implement that.
+#if TEST_STD_VER <= 17
     foo  = u8" "sv;     assert( foo.size() == 1);
+#endif
     Lfoo =  L" "sv;     assert(Lfoo.size() == 1);
     ufoo =  u" "sv;     assert(ufoo.size() == 1);
     Ufoo =  U" "sv;     assert(Ufoo.size() == 1);
 
     foo  =   "ABC"sv;     assert( foo ==   "ABC");   assert( foo == std::string_view   (  "ABC"));
+//	This is changed by P0482 to return a std::u8string - re-enable when we implement that.
+#if TEST_STD_VER <= 17
     foo  = u8"ABC"sv;     assert( foo == u8"ABC");   assert( foo == std::string_view   (u8"ABC"));
+#endif
     Lfoo =  L"ABC"sv;     assert(Lfoo ==  L"ABC");   assert(Lfoo == std::wstring_view  ( L"ABC"));
     ufoo =  u"ABC"sv;     assert(ufoo ==  u"ABC");   assert(ufoo == std::u16string_view( u"ABC"));
     Ufoo =  U"ABC"sv;     assert(Ufoo ==  U"ABC");   assert(Ufoo == std::u32string_view( U"ABC"));
 
     static_assert(  "ABC"sv.size() == 3, "");
+//	This is changed by P0482 to return a std::u8string - re-enable when we implement that.
+#if TEST_STD_VER <= 17
     static_assert(u8"ABC"sv.size() == 3, "");
+#endif
     static_assert( L"ABC"sv.size() == 3, "");
     static_assert( u"ABC"sv.size() == 3, "");
     static_assert( U"ABC"sv.size() == 3, "");
 
     static_assert(noexcept(  "ABC"sv), "");
+//	This is changed by P0482 to return a std::u8string - re-enable when we implement that.
+#if TEST_STD_VER <= 17
     static_assert(noexcept(u8"ABC"sv), "");
+#endif
     static_assert(noexcept( L"ABC"sv), "");
     static_assert(noexcept( u"ABC"sv), "");
     static_assert(noexcept( U"ABC"sv), "");




More information about the libcxx-commits mailing list