[PATCH] D54772: [libcxx] Reorganize tests since the application of P0602R4

Marshall Clow via Phabricator reviews at reviews.llvm.org
Tue Nov 20 14:19:13 PST 2018


mclow.lists added inline comments.


================
Comment at: libcxx/test/std/utilities/optional/optional.object/optional.object.assign/copy.pass.cpp:56
         using O = optional<int>;
+#if TEST_STD_VER >= 20
         LIBCPP_STATIC_ASSERT(assign_empty(O{42}), "");
----------------
For future proofing, we never explicitly test for unreleased standard versions .
Instead, we say `TEST_STD_VER > 17`


================
Comment at: libcxx/www/upcoming_meeting.html:53
 	<tr><td><a href="https://wg21.link/P0487R0">P0487R0</a></td><td>LWG</td><td>Fixing operator>> (basic_istream&, CharT*) (LWG 2499)</td><td>San Diego</td><td><i> </i></td></tr>
-	<tr><td><a href="https://wg21.link/P0602R3">P0602R3</a></td><td>LWG</td><td>variant and optional should propagate copy/move triviality</td><td>San Diego</td><td><i> </i></td></tr>
 	<tr><td><a href="https://wg21.link/P0655R0">P0655R0</a></td><td>LWG</td><td>visit<R>: Explicit Return Type for visit</td><td>San Diego</td><td><i> </i></td></tr>
----------------
You don't have to edit this file.


Repository:
  rCXX libc++

https://reviews.llvm.org/D54772





More information about the libcxx-commits mailing list