[PATCH] D54673: Fix some `-Wshadow` diagnostics emitted by Clang trunk

[Arthur O'Dwyer via Phabricator]

Quuxplusone added a comment.

> This is what I see when building make -j5 check-cxx with Clang trunk (built from source) on OS X.

I discovered yesterday that `make check-cxx` actually uses the system compiler by default, so therefore I had //not// been using Clang trunk; I had been using

  $ clang --version
  Apple LLVM version 7.3.0 (clang-703.0.31)
  Target: x86_64-apple-darwin15.6.0
  Thread model: posix
  InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

With Clang trunk, I don't see `-Wshadow` warnings after all.


Repository:
  rCXX libc++

https://reviews.llvm.org/D54673