[PATCH] D53796: [libcxx] Use AS_NEEDED command for linker script inputs

Fangrui Song via Phabricator reviews at reviews.llvm.org
Mon Nov 5 18:01:50 PST 2018


MaskRay added a comment.

Is this patch still needed now that Fuchsia uses:

  CmdArgs.push_back("--push-state");
  CmdArgs.push_back("--as-needed");
  if (OnlyLibstdcxxStatic)
    CmdArgs.push_back("-Bstatic");
  ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs);
  if (OnlyLibstdcxxStatic)
    CmdArgs.push_back("-Bdynamic");
  CmdArgs.push_back("-lm");
  CmdArgs.push_back("--pop-state");


Repository:
  rCXX libc++

https://reviews.llvm.org/D53796





More information about the libcxx-commits mailing list