[PATCH] D53994: Fixing lower bound regression in certain situations.

Denis Yaroshevskiy via Phabricator reviews at reviews.llvm.org
Thu Nov 1 14:06:50 PDT 2018


dyaroshev added a comment.

In https://reviews.llvm.org/D53994#1284436, @ldionne wrote:

> I did not participate in the original review, but my preference would be for https://reviews.llvm.org/D52697 to be reverted until the cause of the regression is understood and fixed. Unless other maintainers disagree.
>
> I'm a bit uneasy with checking-in a fix to an issue that is not well understood -- this is the standard library, after all, and we run on all kinds of platforms in all kinds of environments. "It works on my machine" usually does not mean much.


I'm very much behind you.


Repository:
  rCXX libc++

https://reviews.llvm.org/D53994





More information about the libcxx-commits mailing list