[PATCH] D54726: [libcxx] Support generating linker script for static library
Petr Hosek via Phabricator
reviews at reviews.llvm.org
Thu Dec 20 17:02:33 PST 2018
phosek added inline comments.
Comment at: libcxx/utils/gen_link_script.py:22
+ action="store_true", default=False)
+ parser.add_argument("input", help="Path to libc++ library")
+ parser.add_argument("output", help="Path to libc++ linker script")
> phosek wrote:
> > ldionne wrote:
> > > Please consider making these named parameters instead of positional parameters. That would have answered some of my questions before I had to ask them.
> > I find it little awkward to use optional arguments as required arguments but I can do that if you prefer?
> You can have required named arguments: `parser.add_argument('--foo', required=True)`. https://docs.python.org/2.7/library/argparse.html#required
I know, I was just pointing out that I find it a little awkward to use "optional" arguments as required arguments which is what "positional" is typically used for, but that's just my personal preference. I'm fine changing that if you prefer.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits