[PATCH] D55920: A fix of __pstl namespace usage.
Louis Dionne via Phabricator
reviews at reviews.llvm.org
Thu Dec 20 12:12:16 PST 2018
ldionne added a comment.
In D55920#1337841 <https://reviews.llvm.org/D55920#1337841>, @rodgert wrote:
> In D55920#1337835 <https://reviews.llvm.org/D55920#1337835>, @ldionne wrote:
> > In libc++ we usually prefer mangling everything that is not explicitly intended to be part of the API. Otherwise it requires reasoning like "oh wait, this name is actually already reserved so let's save 2 characters". Consistency wins IMO.
> I'm not opposed to changing it...we just decided to leave it as is for the initial libstc++ commit. I have several changes from the libstdc++ integration which I need to merge with this version, which include catching a few more places where I missed the mangling on my first pass. I'll take the todo to also fix internal => __internal as part of that patch series over the next few days.
Sounds great! Thanks a lot!
CHANGES SINCE LAST ACTION
More information about the libcxx-commits