[PATCH] D55889: The initial commit of the Parallel STL upstream
Mikhail Dvorskiy via Phabricator
reviews at reviews.llvm.org
Thu Dec 20 01:59:12 PST 2018
MikeDvorskiy marked 3 inline comments as done.
MikeDvorskiy added inline comments.
Comment at: .clang-format:10
What do you mean?
Comment at: .clang-format:13
> Shouldn't we follow LLVM here?
As far as Parallel STL is going to be a part of libcxx library, I've chosen the values of the options to have consistent style with the real format style of "libcxx" source code, for example see libcxx/include/algorithm file (https://github.com/llvm-mirror/libcxx/blob/master/include/algorithm).
Comment at: .clang-format:15
+# Disable formatting options which may break tests.
> What tests break?
Actually, it was taken from LLVM, libcxx/.clang-format
And I agree with it, at least with "SortIncludes: false" due to it can break compilation of the tests (and another user's code). For example the test include first a test configuration file which defines several macros..
CHANGES SINCE LAST ACTION
More information about the libcxx-commits