[PATCH] D55777: [libcxx] Portability fix: add missing includes and static_casts.

Louis Dionne via Phabricator reviews at reviews.llvm.org
Wed Dec 19 07:15:49 PST 2018

ldionne added a comment.

In D55777#1335694 <https://reviews.llvm.org/D55777#1335694>, @amakc11 wrote:

> I don't use clang. The log of running tests including `poisoned_hash_helper.hpp` is attached.
>  F7718494: poisoned_helper_tests.log <https://reviews.llvm.org/F7718494>

Please start running the test suite with Clang before submitting patches here. Every single time you submit a patch, it doesn't build for me or one of the other maintainers -- that doesn't work.

Don't get me wrong -- I strongly appreciate you cleaning up the test suite, however contributing patches that don't work on the main implementation used to run the test suite is not a viable way forward.



More information about the libcxx-commits mailing list