[PATCH] D55763: [Sparc] Add Sparc V8 support

Daniel Cederman via Phabricator reviews at reviews.llvm.org
Tue Dec 18 01:15:31 PST 2018

dcederman marked an inline comment as done.
dcederman added inline comments.

Comment at: src/UnwindLevel1.c:495
                        (void *)context, result);
-  return (uintptr_t)result;
+  return (uintptr_t)__builtin_extract_return_addr((void*)result);
mstorsjo wrote:
> How widely is this builtin available, e.g. on older versions of clang or in gcc?
Looks like it has been available since 1997 for GCC and 2009 for Clang. But looking into it I think it would be better to follow the same approach as aarch64 and modify the return address in stepWithDwarf instead, without using the builtin. That would also allow for better handling of functions that returns structs.



More information about the libcxx-commits mailing list