[PATCH] D55791: [libcxx] Simplify conditional definition of _LIBCPP_HAS_NO_ALIGNED_ALLOCATION
Louis Dionne via Phabricator
reviews at reviews.llvm.org
Mon Dec 17 14:36:12 PST 2018
ldionne added a comment.
I'm putting up a review for this simple change in case the intent was to allow users to define `_LIBCPP_HAS_NO_ALIGNED_ALLOCATION` before including a libc++ header. I don't expect that was the intent, but just in case.
If that happens to be true, I think that intent should be documented and a CMake `#define` should be added. I'd also like to understand why that use case is something we need to support.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits