[PATCH] D55746: [libcxx] [test] [re.traits] Correct expected values for invalid UTF-8

Michał Górny via Phabricator reviews at reviews.llvm.org
Mon Dec 17 08:35:27 PST 2018

mgorny added a comment.

In D55746#1333027 <https://reviews.llvm.org/D55746#1333027>, @mclow.lists wrote:

> Also, is there a corresponding change that needs to be made for `whcar_t`?

No. `wchar_t` normally does not use multi-wchar_t encoding, at least within the tested range.

In D55746#1333035 <https://reviews.llvm.org/D55746#1333035>, @mclow.lists wrote:

> This updated test fails on Mac OS X. (the assert on line 48 fires)

Well, that's what I suspected. I presume that it worked with the previous version just fine. Therefore, we have different implementations making different assumptions as to what to do with `\xDA`.

I don't think killing the whole test on some implementations like we're doing right now makes sense. Either we should stop testing the 'undefined behavior', or maybe allow for both values.



More information about the libcxx-commits mailing list