[PATCH] D55763: [Sparc] Add Sparc V8 support

Daniel Cederman via Phabricator reviews at reviews.llvm.org
Mon Dec 17 07:17:26 PST 2018


dcederman added inline comments.


================
Comment at: src/DwarfParser.hpp:687
 #endif
+    case DW_CFA_GNU_window_save:
+      for (reg = UNW_SPARC_O0; reg <= UNW_SPARC_O7; reg++) {
----------------
mclow.lists wrote:
> Should this be wrapped in `#ifdef _LIBUNWIND_TARGET_SPARC ` ?
Yes, it probably should. I will fix that.


Repository:
  rUNW libunwind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55763/new/

https://reviews.llvm.org/D55763





More information about the libcxx-commits mailing list