[PATCH] D55746: [libcxx] [test] [re.traits] Remove asserts failing due to invalid UTF-8

Michał Górny via Phabricator reviews at reviews.llvm.org
Sun Dec 16 11:34:46 PST 2018

mgorny created this revision.
mgorny added reviewers: krytarowski, joerg, EricWF, howard.hinnant.
Herald added a subscriber: ldionne.

Remove the two test cases for \xDA and \xFA with UTF-8 locale, as both
characters alone are invalid in UTF-8 (short sequences).  Upon removing
them, the test passes on Linux again (and also on NetBSD, after adding
appropriate locale configuration).

  rCXX libc++



Index: test/std/re/re.traits/translate_nocase.pass.cpp
--- test/std/re/re.traits/translate_nocase.pass.cpp
+++ test/std/re/re.traits/translate_nocase.pass.cpp
@@ -19,9 +19,6 @@
 // XFAIL: with_system_cxx_lib=macosx10.7
 // XFAIL: with_system_cxx_lib=macosx10.8
-// TODO: investigation needed
-// XFAIL: linux-gnu
 #include <regex>
 #include <cassert>
@@ -47,8 +44,6 @@
         assert(t.translate_nocase('.') == '.');
         assert(t.translate_nocase('a') == 'a');
         assert(t.translate_nocase('1') == '1');
-        assert(t.translate_nocase('\xDA') == '\xFA');
-        assert(t.translate_nocase('\xFA') == '\xFA');
         std::regex_traits<wchar_t> t;

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55746.178405.patch
Type: text/x-patch
Size: 753 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20181216/865dd809/attachment.bin>

More information about the libcxx-commits mailing list