[PATCH] D55674: [libunwind] [SEH] Add initial support for AArch64

Thu Dec 13 23:52:12 PST 2018

mstorsjo marked 2 inline comments as done.
mstorsjo added inline comments.

================
Comment at: src/Unwind-seh.cpp:175-176
     exc->private_[2] = disp->TargetPc;
     unw_get_reg(&cursor, UNW_ARM_R0, &retval);
     unw_get_reg(&cursor, UNW_ARM_R1, &exc->private_[3]);
 #endif
----------------
cdavis5x wrote:
> This looks suspicious for AArch64... I guess the values for `UNW_ARM_R0` and `UNW_ARM64_X0` are the same.
Oh, good catch. Yes, they have the same values, but I shouldn't (and didn't intend to) rely on that.

Repository:
  rUNW libunwind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55674/new/

https://reviews.llvm.org/D55674