[libcxx] r348867 - [NFC] Fix incorrect (but unreachable) LIT error message

Louis Dionne ldionne at apple.com
Tue Dec 11 09:05:21 PST 2018


Author: ldionne
Date: Tue Dec 11 09:05:20 2018
New Revision: 348867

URL: http://llvm.org/viewvc/llvm-project?rev=348867&view=rev
Log:
[NFC] Fix incorrect (but unreachable) LIT error message

It is unreachable because we test that the cxx_stdlib_under_test is
in the supported set of libraries elsewhere. Furthermore, this code
relied on the `use_stdlib_type`, which is never defined.

Modified:
    libcxx/trunk/utils/libcxx/test/config.py

Modified: libcxx/trunk/utils/libcxx/test/config.py
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/utils/libcxx/test/config.py?rev=348867&r1=348866&r2=348867&view=diff
==============================================================================
--- libcxx/trunk/utils/libcxx/test/config.py (original)
+++ libcxx/trunk/utils/libcxx/test/config.py Tue Dec 11 09:05:20 2018
@@ -757,9 +757,7 @@ class Configuration(object):
             elif self.cxx_stdlib_under_test == 'cxx_default':
                 self.cxx.link_flags += ['-pthread']
             else:
-                self.lit_config.fatal(
-                    'unsupported value for "use_stdlib_type": %s'
-                    %  use_stdlib_type)
+                self.lit_config.fatal('invalid stdlib under test')
 
         link_flags_str = self.get_lit_conf('link_flags', '')
         self.cxx.link_flags += shlex.split(link_flags_str)




More information about the libcxx-commits mailing list