[PATCH] D55537: Should not export public functions implemented in assembly when build static lib on Windows

Martin Storsjö via Phabricator reviews at reviews.llvm.org
Mon Dec 10 23:40:24 PST 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL348832: Don't export assembly functions when function visibility annotations are… (authored by mstorsjo, committed by ).
Herald added a subscriber: llvm-commits.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55537/new/

https://reviews.llvm.org/D55537

Files:
  libunwind/trunk/src/assembly.h


Index: libunwind/trunk/src/assembly.h
===================================================================
--- libunwind/trunk/src/assembly.h
+++ libunwind/trunk/src/assembly.h
@@ -76,7 +76,11 @@
   .section .drectve,"yn" SEPARATOR                        \
   .ascii "-export:", #name, "\0" SEPARATOR                \
   .text
+#if defined(_LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS)
+#define EXPORT_SYMBOL(name)
+#else
 #define EXPORT_SYMBOL(name) EXPORT_SYMBOL2(name)
+#endif
 #define HIDDEN_SYMBOL(name)
 
 #define NO_EXEC_STACK_DIRECTIVE


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55537.177664.patch
Type: text/x-patch
Size: 540 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20181211/055a264b/attachment.bin>


More information about the libcxx-commits mailing list