[PATCH] D55517: Remove `_VSTD`

Eric Fiselier via Phabricator reviews at reviews.llvm.org
Mon Dec 10 10:59:22 PST 2018

EricWF added a comment.

In D55517#1325841 <https://reviews.llvm.org/D55517#1325841>, @mclow.lists wrote:

> In D55517#1325829 <https://reviews.llvm.org/D55517#1325829>, @ldionne wrote:
> > I personally like this change but I'd wait a bit to see whether other people oppose (and why) before submitting.
> I do not like this change.
>  I think that the loss of flexibility may come back to bite us in the future.

I would need to see a concrete example of the currently opaque "functionality" you're imagining before I can give this argument any credence.

> However, my main objection is that `_VSTD` is a noticeable chuck of all caps in the source code; it's an indication that we're deliberately qualifying something to disable ADL.
>  `std` is much less "in your face" - i.e, easier to miss.

This should be enforced using tooling then.

Also, I'm less worried about being able to spot qualified calls (they're almost certainly correctly qualified). Seeing incorrectly unqualified calls is of more value.

  rCXX libc++



More information about the libcxx-commits mailing list