[PATCH] D55517: Remove `_VSTD`
JF Bastien via Phabricator
reviews at reviews.llvm.org
Mon Dec 10 10:48:22 PST 2018
jfb added a comment.
In D55517#1325829 <https://reviews.llvm.org/D55517#1325829>, @ldionne wrote:
> In D55517#1325586 <https://reviews.llvm.org/D55517#1325586>, @jfb wrote:
> > > Quick Question: What's the difference between writing `_VSTD::` and `std::`? Nothing.
> > I thought it was `std:: _LIBCPP_ABI_NAMESPACE` ?
> That's correct, however I don't think it's a big deal. Indeed, discussed it and we couldn't find a reason why we would ever want to call a function that is not in the current ABI's namespace. And even if we did, we could always use `std::<ABI namespace>::function`.
Sure, my point is that the commit message isn't right, and should be updated to have this rationale.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits