[PATCH] D55308: Implement the second part of P0482 (char8_t)

Marshall Clow via Phabricator reviews at reviews.llvm.org
Sun Dec 9 11:45:44 PST 2018


mclow.lists marked an inline comment as done.
mclow.lists added inline comments.


================
Comment at: include/__string:404
+
+    static inline constexpr void assign(char_type& __c1, const char_type& __c2) noexcept
+        {__c1 = __c2;}
----------------
mclow.lists wrote:
> ldionne wrote:
> > `_LIBCPP_INLINE_VISIBILITY` here and below.
> Right.
After talking with Louis, we decided that *all* of the `char_traits` stuff needs `_LIBCPP_INLINE_VISIBILITY` pixie dust (for the case when `_LIBCPP_HIDE_FROM_ABI_PER_TU` is defined), but we'll handle that in a different patch.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55308/new/

https://reviews.llvm.org/D55308





More information about the libcxx-commits mailing list