[PATCH] D55045: Add a version of std::function that includes a few optimizations.

Louis Dionne via Phabricator reviews at reviews.llvm.org
Fri Dec 7 12:10:01 PST 2018


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I think I'm fine with this, but I'd still like to better understand the positive performance impact of the change. When we spoke @EricWF said he could provide an interpretation.

Thanks for the work!



================
Comment at: include/functional:2165
 {
-    typedef __function::__base<_Rp(_ArgTypes...)> __base;
-    typename aligned_storage<3*sizeof(void*)>::type __buf_;
-    __base* __f_;
+    // TODO: REMOVE BEFORE SUBMITTING!
+#define _LIBCPP_ABI_OPTIMIZED_FUNCTION
----------------
Please remove. :-)


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55045/new/

https://reviews.llvm.org/D55045





More information about the libcxx-commits mailing list