[PATCH] D55366: [libcxx] Add checks for unique value of array<T, 0>.begin() and array<T, 0>.end() .

Marshall Clow via Phabricator reviews at reviews.llvm.org
Thu Dec 6 10:33:48 PST 2018


mclow.lists added a comment.

In D55366#1321351 <https://reviews.llvm.org/D55366#1321351>, @amakc11 wrote:

> In libc++ these array iterators declared as follows:
>
>   typedef value_type*                        iterator;
>   typedef const value_type*                  const_iterator;
>   
>   


Yes, but that's just true for libc++. Other library maintainers use these tests, too.
(and frankly, I screwed up when I implemented `<array>`. Those iterators should not be pointers)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55366/new/

https://reviews.llvm.org/D55366





More information about the libcxx-commits mailing list