[libcxx] r348509 - [libcxx] Add checks for unique value of array<T, 0>.begin() and array<T, 0>.end()

[Louis Dionne]

Author: ldionne
Date: Thu Dec  6 10:24:39 2018
New Revision: 348509

URL: http://llvm.org/viewvc/llvm-project?rev=348509&view=rev
Log:
[libcxx] Add checks for unique value of array<T, 0>.begin() and array<T, 0>.end()

The standard section [array.zero] requires the return value of begin()
and end() methods of a zero-sized array to be unique. Eric Fiselier
clarifies: "That unique value cannot be null, and must be properly aligned".
This patch adds checks for the first part of this clarification: unique
value returned by these methods cannot be null.

Reviewed as https://reviews.llvm.org/D55366.
Thanks to Andrey Maksimov for the patch.

Modified:
    libcxx/trunk/test/std/containers/sequences/array/begin.pass.cpp

Modified: libcxx/trunk/test/std/containers/sequences/array/begin.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/std/containers/sequences/array/begin.pass.cpp?rev=348509&r1=348508&r2=348509&view=diff
==============================================================================
--- libcxx/trunk/test/std/containers/sequences/array/begin.pass.cpp (original)
+++ libcxx/trunk/test/std/containers/sequences/array/begin.pass.cpp Thu Dec  6 10:24:39 2018
@@ -14,6 +14,8 @@
 #include <array>
 #include <cassert>
 
+#include "test_macros.h"
+
 // std::array is explicitly allowed to be initialized with A a = { init-list };.
 // Disable the missing braces warning for this reason.
 #include "disable_missing_braces_warning.h"
@@ -40,6 +42,11 @@ int main()
       typedef NoDefault T;
       typedef std::array<T, 0> C;
       C c = {};
-      assert(c.begin() == c.end());
+      C::iterator ib, ie;
+      ib = c.begin();
+      ie = c.end();
+      assert(ib == ie);
+      LIBCPP_ASSERT(ib != nullptr);
+      LIBCPP_ASSERT(ie != nullptr);
     }
 }