[PATCH] D55366: [libcxx] Add checks for unique value of array<T, 0>.begin() and array<T, 0>.end() .

Louis Dionne via Phabricator reviews at reviews.llvm.org
Thu Dec 6 06:00:12 PST 2018


ldionne added inline comments.


================
Comment at: test/std/containers/sequences/array/begin.pass.cpp:47
+      assert(ib == ie);
+      assert(ib != nullptr);
+      assert(ie != nullptr);
----------------
Comparing the iterator to `nullptr` assumes the iterators to be pointers, which I don't think is required. They're only required to be contiguous iterators.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55366/new/

https://reviews.llvm.org/D55366





More information about the libcxx-commits mailing list