[PATCH] D55308: Implement the second part of P0482 (char8_t)
Marshall Clow via Phabricator
reviews at reviews.llvm.org
Wed Dec 5 14:52:39 PST 2018
mclow.lists marked 3 inline comments as done.
mclow.lists added inline comments.
Comment at: test/std/strings/basic.string.hash/enabled_hashes.pass.cpp:26
+#if defined(__cpp_lib_char8_t) && __cpp_lib_char8_t >= 201811L
> Why would the value ever be less than `201811L`? Genuinely asking.
No, but it could get bigger (if we add other `char8_t` stuff, and then the test for the new stuff would be:
`#if defined(__cpp_lib_char8_t) && __cpp_lib_char8_t >= 201903L`, so I just used the same pattern.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits