<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jan 27, 2020, at 11:35, vali asdas <<a href="mailto:vali.asdas@yahoo.ro" class="">vali.asdas@yahoo.ro</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><!--[if gte mso 9]><xml><o:OfficeDocumentSettings><o:AllowPNG/><o:PixelsPerInch>96</o:PixelsPerInch></o:OfficeDocumentSettings></xml><![endif]--><div class=""><div class="ydpd49e9ff4yahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:13px;"><div class=""></div>
<div dir="ltr" data-setdir="false" class="">Hi. So why put constexpr at 319?<br class=""></div></div></div></div></blockquote><div><br class=""></div><div>It’s not needed but it doesn’t hurt.</div><div><br class=""></div><div>Louis</div><br class=""><blockquote type="cite" class=""><div class=""><div class=""><div class="ydpd49e9ff4yahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:13px;"><div class=""><br class=""></div>
</div><div id="yahoo_quoted_0407296984" class="yahoo_quoted">
<div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;" class="">
<div class="">
Pe luni, 27 ianuarie 2020, 21:12:21 EET, Louis Dionne <<a href="mailto:ldionne@apple.com" class="">ldionne@apple.com</a>> a scris:
</div>
<div class=""><br class=""></div>
<div class=""><br class=""></div>
<div class=""><div id="yiv6213918262" class=""><div class="">We can’t use `if constexpr` there, since `__i` is not a constant expression from within the function. So `__matches[__i]` is not a constant expression.<div class="yiv6213918262"><br class="yiv6213918262" clear="none"></div><div class="yiv6213918262">It doesn’t matter though, since the function `__find_index` will always result in a constant expression, and so we wouldn’t gain anything from using `if constexpr` there.</div><div class="yiv6213918262"><br class="yiv6213918262" clear="none"></div><div class="yiv6213918262">Louis<br class="yiv6213918262" clear="none"><div class=""><br class="yiv6213918262" clear="none"><blockquote class="yiv6213918262" type="cite"><div class="yiv6213918262yqt6457106196" id="yiv6213918262yqt69192"><div class="yiv6213918262">On Jul 18, 2019, at 04:27, vali asdas via libcxx-bugs <<a rel="nofollow" shape="rect" class="yiv6213918262" ymailto="mailto:libcxx-bugs@lists.llvm.org" target="_blank" href="mailto:libcxx-bugs@lists.llvm.org">libcxx-bugs@lists.llvm.org</a>> wrote:</div><br class="yiv6213918262Apple-interchange-newline" clear="none"><div class="yiv6213918262"><div class="yiv6213918262"><div class="yiv6213918262yahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:13px;"><div class="yiv6213918262" dir="ltr">Hey there,</div><div class="yiv6213918262" dir="ltr"><br class="yiv6213918262" clear="none"></div><div class="yiv6213918262" dir="ltr">Line 322 here <span class="yiv6213918262"><a rel="nofollow" shape="rect" class="yiv6213918262enhancr_card_4363589118" target="_blank" href="https://github.com/llvm-mirror/libcxx/blob/master/include/variant">llvm-mirror/libcxx</a> is an if with a constant expression inside. Shouldn't it be using if constexpr? It should be a direct replacement, since if constexpr and std::variant are both from C++ 17 anyway.Thanks.</span><div class="yiv6213918262"><br class="yiv6213918262" clear="none"></div><div class="yiv6213918262ydp7dc3ee08ymail-preserve-style yiv6213918262ydp7dc3ee08yahoo-link-enhancr-card yiv6213918262ydp7dc3ee08ymail-preserve-class" id="yiv6213918262ydp7dc3ee08enhancr_card_4363589118" style="max-width:400px;" data-url="https://github.com/llvm-mirror/libcxx/blob/master/include/variant" data-type="YENHANCER" data-size="MEDIUM"><a rel="nofollow" shape="rect" class="yiv6213918262ydp7dc3ee08yahoo-enhancr-cardlink" target="_blank" href="https://github.com/llvm-mirror/libcxx/blob/master/include/variant" style="text-decoration:none !important;"><table class="yiv6213918262ydp7dc3ee08yahoo-ignore-table yiv6213918262ydp7dc3ee08card-wrapper" style="max-width:400px;" cellspacing="0" cellpadding="0" border="0"><tbody class="yiv6213918262"><tr class="yiv6213918262"><td colspan="1" rowspan="1" class="yiv6213918262" width="400"><table class="yiv6213918262ydp7dc3ee08card yiv6213918262ydp7dc3ee08yahoo-ignore-table" style="max-width:400px;border-width:1px;border-style:solid;border-color:rgb(224, 228, 233);border-radius:2px;" width="100%" cellspacing="0" cellpadding="0" border="0"><tbody class="yiv6213918262"><tr class="yiv6213918262"><td colspan="1" rowspan="1" class="yiv6213918262ydp7dc3ee08card-primary-image-cell" style="background-color:rgb(0, 0, 0);background-size:cover;position:relative;border-radius:2px 2px 0px 0px;min-height:175px;" valign="top" height="175" bgcolor="#000000" background="https://s.yimg.com/lo/api/res/1.2/KxB1MAitW3a8MIqqAMVsGA--~A/Zmk9ZmlsbDt3PTQwMDtoPTIwMDthcHBpZD1pZXh0cmFjdA--/https://avatars2.githubusercontent.com/u/1386314?s=400&v=4.cf.jpg"><table class="yiv6213918262ydp7dc3ee08yahoo-ignore-table yiv6213918262ydp7dc3ee08card-overlay-container-table" style="width:100%;" cellspacing="0" cellpadding="0" border="0"><tbody class="yiv6213918262"><tr class="yiv6213918262"><td colspan="1" rowspan="1" class="yiv6213918262ydp7dc3ee08card-overlay-cell" style="background-color:transparent;border-radius:2px 2px 0px 0px;min-height:175px;" valign="top" bgcolor="transparent" background="https://s.yimg.com/cv/ae/nq/storm/assets/enhancrV21/1/enhancr_gradient-400x175.png"><table class="yiv6213918262ydp7dc3ee08yahoo-ignore-table" style="width:100%;min-height:175px;" height="175" border="0"><tbody class="yiv6213918262"><tr class="yiv6213918262"><td colspan="1" rowspan="1" class="yiv6213918262ydp7dc3ee08card-richInfo2" style="text-align:left;padding:15px 0 0 15px;vertical-align:top;"></td><td colspan="1" rowspan="1" class="yiv6213918262ydp7dc3ee08card-actions" style="text-align:right;padding:15px 15px 0 0;vertical-align:top;"><div class="yiv6213918262ydp7dc3ee08card-share-container"></div></td></tr></tbody></table></td></tr></tbody></table></td></tr><tr class="yiv6213918262"><td colspan="1" rowspan="1" class="yiv6213918262"><table class="yiv6213918262ydp7dc3ee08yahoo-ignore-table yiv6213918262ydp7dc3ee08card-info" style="background:#fff;position:relative;z-index:2;width:100%;max-width:400px;border-radius:0 0 2px 2px;border-top:1px solid rgb(224, 228, 233);" cellspacing="0" cellpadding="0" border="0" align="center"><tbody class="yiv6213918262"><tr class="yiv6213918262"><td colspan="1" rowspan="1" class="yiv6213918262" style="background-color:#ffffff;padding:16px 0 16px 12px;vertical-align:top;border-radius:0 0 0 2px;"><img class="yiv6213918262ydp7dc3ee08yahoo-ignore-inline-image yiv6213918262ydp7dc3ee08card-object-1 yiv6213918262ydp7dc3ee08ymail-preserve-class" src="https://s.yimg.com/nq/storm/assets/enhancrV2/23/logos/github.png" style="min-width:36px;margin-top:3px;" height="36"></td><td colspan="1" rowspan="1" class="yiv6213918262" style="vertical-align:middle;padding:12px 24px 16px 12px;width:99%;"><h2 class="yiv6213918262ydp7dc3ee08card-title" style="font-size:14px;line-height:19px;margin:0px 0px 6px;">llvm-mirror/libcxx</h2><div class="yiv6213918262" style="font-size:12px;line-height:16px;margin:0px;color:rgb(151, 155, 167);">Mirror of official libcxx git repository located at http://llvm.org/git/libcxx. Updated every five minutes. - ll...</div></td></tr></tbody></table></td></tr></tbody></table></td></tr></tbody></table></a></div><div class="yiv6213918262"><br class="yiv6213918262" clear="none"></div><div class="yiv6213918262"><br class="yiv6213918262" clear="none"></div></div></div></div>_______________________________________________<br class="yiv6213918262" clear="none">libcxx-bugs mailing list<br class="yiv6213918262" clear="none"><a rel="nofollow" shape="rect" class="yiv6213918262" ymailto="mailto:libcxx-bugs@lists.llvm.org" target="_blank" href="mailto:libcxx-bugs@lists.llvm.org">libcxx-bugs@lists.llvm.org</a><br class="yiv6213918262" clear="none"><a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-bugs" class="">https://lists.llvm.org/cgi-bin/mailman/listinfo/libcxx-bugs</a><br class="yiv6213918262" clear="none"></div></div></blockquote></div><br class="yiv6213918262" clear="none"></div></div></div></div>
</div>
</div></div></div></blockquote></div><br class=""></body></html>