<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 29 Jan 2018, at 04:02, Jan Vesely <<a href="mailto:jan.vesely@rutgers.edu" class="">jan.vesely@rutgers.edu</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On Thu, 2018-01-18 at 16:19 -0500, Jan Vesely wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">On Thu, 2018-01-18 at 20:43 +0100, Jeroen Ketema wrote:<br class=""><blockquote type="cite" class="">This whole patch set LGTM.<br class=""></blockquote><br class="">thanks for quick review<br class=""><br class=""><blockquote type="cite" class=""><br class=""><blockquote type="cite" class="">On 18 Jan 2018, at 00:41, Jan Vesely via Libclc-dev <<a href="mailto:libclc-dev@lists.llvm.org" class="">libclc-dev@lists.llvm.org</a>> wrote:<br class=""><br class="">v2: Use full precision implementation<br class=""><br class="">Signed-off-by: Jan Vesely <<a href="mailto:jan.vesely@rutgers.edu" class="">jan.vesely@rutgers.edu</a>><br class="">---<br class="">Fails CTS as well. It should probably be left out for now.<br class=""></blockquote><br class="">I don’t have any issues with committing this, as the real failure is not in this code.<br class=""></blockquote></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Hi Jeroen,</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">would you prefer this version(v2) for consistency, or v3?</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""></div></blockquote><div><br class=""></div><div>Personally, I would just go for v2.</div><div><br class=""></div><div>Jeroen</div><br class=""><blockquote type="cite" class=""><div class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">thanks,</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Jan</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class=""><br class="">I've posted a workaround that passes the CTS. I'm not sure which<br class="">version is preferable. since the workaround clearly hides an issue in<br class="">the original powr implementation.<br class=""><br class="">Jan<br class=""><br class=""><blockquote type="cite" class=""><br class="">Jeroen<br class=""><br class=""><blockquote type="cite" class=""><br class="">generic/include/clc/clc.h | 1 +<br class="">generic/include/clc/math/half_powr.h | 7 +++++++<br class="">generic/lib/SOURCES | 1 +<br class="">generic/lib/math/half_powr.cl | 6 ++++++<br class="">4 files changed, 15 insertions(+)<br class="">create mode 100644 generic/include/clc/math/half_powr.h<br class="">create mode 100644 generic/lib/math/half_powr.cl<br class=""><br class="">diff --git a/generic/include/clc/clc.h b/generic/include/clc/clc.h<br class="">index 930bbfc..fa48639 100644<br class="">--- a/generic/include/clc/clc.h<br class="">+++ b/generic/include/clc/clc.h<br class="">@@ -78,6 +78,7 @@<br class="">#include <clc/math/half_log.h><br class="">#include <clc/math/half_log10.h><br class="">#include <clc/math/half_log2.h><br class="">+#include <clc/math/half_powr.h><br class="">#include <clc/math/half_recip.h><br class="">#include <clc/math/half_rsqrt.h><br class="">#include <clc/math/half_sin.h><br class="">diff --git a/generic/include/clc/math/half_powr.h b/generic/include/clc/math/half_powr.h<br class="">new file mode 100644<br class="">index 0000000..c4e5242<br class="">--- /dev/null<br class="">+++ b/generic/include/clc/math/half_powr.h<br class="">@@ -0,0 +1,7 @@<br class="">+#define __CLC_BODY <clc/math/binary_decl_tt.inc><br class="">+#define __CLC_FUNCTION half_powr<br class="">+<br class="">+#include <clc/math/gentype.inc><br class="">+<br class="">+#undef __CLC_BODY<br class="">+#undef __CLC_FUNCTION<br class="">diff --git a/generic/lib/SOURCES b/generic/lib/SOURCES<br class="">index 9dbd35e..5aa2ba6 100644<br class="">--- a/generic/lib/SOURCES<br class="">+++ b/generic/lib/SOURCES<br class="">@@ -112,6 +112,7 @@ math/half_exp2.cl<br class="">math/half_log.cl<br class="">math/half_log10.cl<br class="">math/half_log2.cl<br class="">+math/half_powr.cl<br class="">math/half_recip.cl<br class="">math/half_rsqrt.cl<br class="">math/half_sin.cl<br class="">diff --git a/generic/lib/math/half_powr.cl b/generic/lib/math/half_powr.cl<br class="">new file mode 100644<br class="">index 0000000..53174d4<br class="">--- /dev/null<br class="">+++ b/generic/lib/math/half_powr.cl<br class="">@@ -0,0 +1,6 @@<br class="">+#include <clc/clc.h><br class="">+<br class="">+#define __CLC_FUNC powr<br class="">+#define __CLC_BODY <half_binary.inc><br class="">+#define __FLOAT_ONLY<br class="">+#include <clc/math/gentype.inc><br class="">--<span class="Apple-converted-space"> </span><br class="">2.14.3<br class=""><br class="">_______________________________________________<br class="">Libclc-dev mailing list<br class=""><a href="mailto:Libclc-dev@lists.llvm.org" class="">Libclc-dev@lists.llvm.org</a><br class="">http://lists.llvm.org/cgi-bin/mailman/listinfo/libclc-dev<br class=""></blockquote><br class=""><br class=""></blockquote></blockquote><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">--<span class="Apple-converted-space"> </span></span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Jan Vesely <</span><a href="mailto:jan.vesely@rutgers.edu" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px;" class="">jan.vesely@rutgers.edu</a><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">></span></div></blockquote></div><br class=""></body></html>