<br><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 6, 2017, 10:37 AM Jan Vesely via Libclc-dev <<a href="mailto:libclc-dev@lists.llvm.org">libclc-dev@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, 2017-09-27 at 18:34 -0400, Jan Vesely wrote:<br>
> AMDGPU targets don't have insturction for it,<br>
> so it'll be expanded to C * log2 anyway.<br>
><br>
> v2: use native_log2 instead of the more precise sw implementation<br>
><br>
> Signed-off-by: Jan Vesely <<a href="mailto:jan.vesely@rutgers.edu" target="_blank">jan.vesely@rutgers.edu</a>><br>
<br>
ping. this is currently crashing.<br>
even after <a href="https://reviews.llvm.org/D29942" rel="noreferrer" target="_blank">https://reviews.llvm.org/D29942</a> lands, we'll need this for<br>
older llvm versions.<br></blockquote></div><div><br></div><div>Even with this, 'pow' crashes out llvm on me at the moment on my SI card.  I've got family in town today yet ,but tonight or tomorrow I should have time to rebuild my stack and try again.</div><div><br></div><div>--Aaron</div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Jan<br>
<br>
> ---<br>
>  generic/lib/math/<a href="http://native_log.cl" rel="noreferrer" target="_blank">native_log.cl</a>  | 5 -----<br>
>  generic/lib/math/native_log.inc | 2 +-<br>
>  2 files changed, 1 insertion(+), 6 deletions(-)<br>
><br>
> diff --git a/generic/lib/math/<a href="http://native_log.cl" rel="noreferrer" target="_blank">native_log.cl</a> b/generic/lib/math/<a href="http://native_log.cl" rel="noreferrer" target="_blank">native_log.cl</a><br>
> index f64f012..f8ba08f 100644<br>
> --- a/generic/lib/math/<a href="http://native_log.cl" rel="noreferrer" target="_blank">native_log.cl</a><br>
> +++ b/generic/lib/math/<a href="http://native_log.cl" rel="noreferrer" target="_blank">native_log.cl</a><br>
> @@ -22,11 +22,6 @@<br>
><br>
>  #include <clc/clc.h><br>
><br>
> -#define __CLC_FUNCTION __clc_native_log<br>
> -#define __CLC_INTRINSIC "llvm.log"<br>
> -#undef cl_khr_fp64<br>
> -#include <clc/math/unary_intrin.inc><br>
> -<br>
>  #define __CLC_BODY <native_log.inc><br>
>  #define __FLOAT_ONLY<br>
>  #include <clc/math/gentype.inc><br>
> diff --git a/generic/lib/math/native_log.inc b/generic/lib/math/native_log.inc<br>
> index cb4db3f..d4950c2 100644<br>
> --- a/generic/lib/math/native_log.inc<br>
> +++ b/generic/lib/math/native_log.inc<br>
> @@ -21,5 +21,5 @@<br>
>   */<br>
><br>
>  _CLC_OVERLOAD _CLC_DEF __CLC_GENTYPE native_log(__CLC_GENTYPE val) {<br>
> -  return __clc_native_log(val);<br>
> +  return native_log2(val) * (1.0f / M_LOG2E_F);<br>
>  }<br>
_______________________________________________<br>
Libclc-dev mailing list<br>
<a href="mailto:Libclc-dev@lists.llvm.org" target="_blank">Libclc-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/libclc-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/libclc-dev</a><br>
</blockquote></div>