[Libclc-dev] [PATCH 1/1] relational/select: Condition types for half are short/ushort, not char/uchar

[Jan Vesely via Libclc-dev]

On Wed, 2018-04-25 at 10:41 -0500, Aaron Watry via Libclc-dev wrote:
> Reviewed-by: Aaron Watry <awatry at gmail.com>
> 
> No measured changed in CTS results for relational_select_signed on RX
> 580 (passes before and after). relational_select_unsigned passes
> afterwards, didn't grab a before sample, but I suspect it passed
> previously.

thanks. yeah, it should not change CTS results, but it fixes
minmag/maxmag fp16.

Jan

> 
> --Aaron
> 
> On Tue, Apr 24, 2018 at 4:41 PM, Jan Vesely via Libclc-dev
> <libclc-dev at lists.llvm.org> wrote:
> > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > ---
> >  generic/include/clc/relational/select.inc | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/generic/include/clc/relational/select.inc b/generic/include/clc/relational/select.inc
> > index 9c4aa67..11a957a 100644
> > --- a/generic/include/clc/relational/select.inc
> > +++ b/generic/include/clc/relational/select.inc
> > @@ -9,8 +9,8 @@
> >  #define __CLC_S_GENTYPE __CLC_XCONCAT(int, __CLC_VECSIZE)
> >  #define __CLC_U_GENTYPE __CLC_XCONCAT(uint, __CLC_VECSIZE)
> >  #elif __CLC_FPSIZE == 16
> > -#define __CLC_S_GENTYPE __CLC_XCONCAT(char, __CLC_VECSIZE)
> > -#define __CLC_U_GENTYPE __CLC_XCONCAT(uchar, __CLC_VECSIZE)
> > +#define __CLC_S_GENTYPE __CLC_XCONCAT(short, __CLC_VECSIZE)
> > +#define __CLC_U_GENTYPE __CLC_XCONCAT(ushort, __CLC_VECSIZE)
> >  #endif
> > 
> >  _CLC_OVERLOAD _CLC_DECL __CLC_GENTYPE select(__CLC_GENTYPE x, __CLC_GENTYPE y, __CLC_S_GENTYPE z);
> > --
> > 2.14.3
> > 
> > _______________________________________________
> > Libclc-dev mailing list
> > Libclc-dev at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/libclc-dev
> 
> _______________________________________________
> Libclc-dev mailing list
> Libclc-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/libclc-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/libclc-dev/attachments/20180425/46bd573f/attachment.sig>