[Libclc-dev] [PATCH 1/1] .travis: Make sure we report failure even if only earlier checked files fail

[Jan Vesely via Libclc-dev]

On Sun, 2017-10-08 at 21:07 +0200, Jeroen Ketema wrote:
> Any specific reason for using the value 2?

I thought it was what the check script returns, but it returns 1.
I'll change  this to ret=1. and also replace '[' with an explicit
'test' to make the script more readable. Do you want me to repost?

> 
> Otherwise, LGTM

thanks,
Jan

> 
> -- Jeroen
> 
> > On 8 Oct 2017, at 12:01, Jan Vesely via Libclc-dev <libclc-dev at lists.llvm.org> wrote:
> > 
> > for loop would only report status of the last command
> > 
> > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > ---
> > .travis.yml | 8 +++++---
> > 1 file changed, 5 insertions(+), 3 deletions(-)
> > 
> > diff --git a/.travis.yml b/.travis.yml
> > index 2f058a7..5f5de72 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -55,6 +55,8 @@ matrix:
> > 
> > script:
> >   - $PYTHON ./configure.py --with-llvm-config=$LLVM_CONFIG --with-cxx-compiler=$CXX && make -j4
> > -  - for f in $CHECK_FILES; do
> > -        ./check_external_calls.sh built_libs/$f;
> > -    done
> > +  - ret=0;
> > +    for f in $CHECK_FILES; do
> > +        ./check_external_calls.sh built_libs/$f || ret=2;
> > +    done;
> > +    [ $ret -eq 0 ]
> > -- 
> > 2.13.6
> > 
> > _______________________________________________
> > Libclc-dev mailing list
> > Libclc-dev at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/libclc-dev
> 
> 

-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/libclc-dev/attachments/20171008/dd667e5d/attachment.sig>