[Libclc-dev] [PATCH 1/1] configure.py: Drop explicit import of int builtin

Aaron Watry via Libclc-dev libclc-dev at lists.llvm.org
Sat Aug 12 11:10:08 PDT 2017


Looks fine to me.

Tested with both python2/3 and verified that the Makefiles were the
same (minus the ordering of line 8024, which has the same SOURCES
files listed in a different order).

--Aaron

On Tue, Aug 8, 2017 at 8:51 AM, Jan Vesely via Libclc-dev
<libclc-dev at lists.llvm.org> wrote:
> I can't reproduce the error that made me add this.
>
> Reported-by: Kim Gräsman <kim.grasman at gmail.com>
> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> ---
>  configure.py | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/configure.py b/configure.py
> index 8e7017d..85004b1 100755
> --- a/configure.py
> +++ b/configure.py
> @@ -1,12 +1,6 @@
>  #!/usr/bin/python
>  from __future__ import print_function
>
> -# We only need this for int() cast, which works by default in python 2
> -try:
> -    from builtins import int
> -except:
> -    pass
> -
>  def c_compiler_rule(b, name, description, compiler, flags):
>    command = "%s -MMD -MF $out.d %s -c -o $out $in" % (compiler, flags)
>    b.rule(name, command, description + " $out", depfile="$out.d")
> --
> 2.13.4
>
> _______________________________________________
> Libclc-dev mailing list
> Libclc-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/libclc-dev


More information about the Libclc-dev mailing list