[Libclc-dev] [PATCH 1/3] amdgcn-amdhsa: Add get_global_size() implementation

Matt Arsenault via Libclc-dev libclc-dev at lists.llvm.org
Wed Sep 14 07:56:49 PDT 2016


> On Sep 14, 2016, at 07:22, Tom Stellard via Libclc-dev <libclc-dev at lists.llvm.org> wrote:
> 
> ---
> amdgcn-amdhsa/lib/SOURCES                     |  1 +
> amdgcn-amdhsa/lib/workitem/get_global_size.ll | 39 +++++++++++++++++++++++++++
> 2 files changed, 40 insertions(+)
> create mode 100644 amdgcn-amdhsa/lib/workitem/get_global_size.ll
> 


I think you should name the labels+values, besides that LGTM


More information about the Libclc-dev mailing list