[Libclc-dev] [PATCH 1/3] 64 bit integers are legal in full profile without an extension

Jan Vesely via Libclc-dev libclc-dev at lists.llvm.org
Thu Jun 16 15:46:46 PDT 2016


On Fri, 2016-06-17 at 00:38 +0200, Vedran Miletić wrote:
> On 06/02/2016 04:02 AM, Tom Stellard via Libclc-dev wrote:
> > On Wed, Jun 01, 2016 at 12:15:34PM -0400, Jan Vesely via Libclc-dev 
> > wrote:
> > > Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> > 
> > LGTM for all three patches.
> > 
> > -Tom
> > 
> 
> Any reason why these three and previous two patches from Jan were
> not 
> applied?

Not for 1/3, but I did not want to push 2/3 and 3/3 before 
http://reviews.llvm.org/D20389 lands.

The current state (build failure for nvptx) is imo preferable to the
alternative of miscompiling nvptx libclc (compiling without
cl_khr_fp64).

the get_global_offset patches depend on:
http://reviews.llvm.org/D20297
http://reviews.llvm.org/D20298

the other dependencies are already accepted:
http://reviews.llvm.org/D20691
http://reviews.llvm.org/D20299

regards,
Jan

> 
> Regards,
> Vedran
> 
-- 
Jan Vesely <jan.vesely at rutgers.edu>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/libclc-dev/attachments/20160616/c25b47fd/attachment.sig>


More information about the Libclc-dev mailing list