[Libclc-dev] [PATCH] amdgcn: Correct return types to be size_t

[Jan Vesely via Libclc-dev]

On Fri, 2016-08-19 at 21:21 -0700, Matt Arsenault wrote:
> > 
> > On Aug 19, 2016, at 20:27, Jan Vesely <jv356 at scarletmail.rutgers.ed
> > u> wrote:
> > 
> > On Fri, 2016-08-19 at 15:33 -0700, Matt Arsenault via Libclc-dev
> > wrote:
> > 
> > Is size_t 64bit even for mesa opencl? the pointer is cast to (uint
> > *).
> > 
> > Jan
> > 
> > > 
> > > _______________________________________________
> > > Libclc-dev mailing list
> > > Libclc-dev at lists.llvm.org
> > > http://lists.llvm.org/cgi-bin/mailman/listinfo/libclc-dev
> clover currently incorrectly reports the device pointer size as 32.
> If something is using uint it is incorrect

ah right, clover hardcodes offsets to cl_uint:

>       case module::argument::grid_offset: {
>          for (cl_uint x : pad_vector(*q, grid_offset, 0)) {
>             auto arg = argument::create(marg);
> 
>             arg->set(sizeof(x), &x);
>             arg->bind(*this, marg);
>          }
>          break;
>       }

that's why it worked with cast to (uint *)

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.llvm.org/pipermail/libclc-dev/attachments/20160820/7c3022f0/attachment.sig>