[Libclc-dev] [PATCH 4/8] Implement fast_length builtin

Aaron Watry awatry at gmail.com
Thu Mar 12 18:40:43 PDT 2015


LGTM

On Fri, Mar 6, 2015 at 7:01 PM, Tom Stellard <thomas.stellard at amd.com>
wrote:

> This implementation was ported from the AMD builtin library
> and has been tested with piglit, OpenCV, and the ocl conformance tests.
> ---
>  generic/include/clc/clc.h                     |  1 +
>  generic/include/clc/geometric/fast_length.h   | 24 +++++++++++
>  generic/include/clc/geometric/fast_length.inc | 23 ++++++++++
>  generic/lib/SOURCES                           |  1 +
>  generic/lib/geometric/fast_length.cl          | 60
> +++++++++++++++++++++++++++
>  5 files changed, 109 insertions(+)
>  create mode 100644 generic/include/clc/geometric/fast_length.h
>  create mode 100644 generic/include/clc/geometric/fast_length.inc
>  create mode 100644 generic/lib/geometric/fast_length.cl
>
> diff --git a/generic/include/clc/clc.h b/generic/include/clc/clc.h
> index d657cad..760a086 100644
> --- a/generic/include/clc/clc.h
> +++ b/generic/include/clc/clc.h
> @@ -117,6 +117,7 @@
>  #include <clc/geometric/cross.h>
>  #include <clc/geometric/distance.h>
>  #include <clc/geometric/dot.h>
> +#include <clc/geometric/fast_length.h>
>  #include <clc/geometric/length.h>
>  #include <clc/geometric/normalize.h>
>
> diff --git a/generic/include/clc/geometric/fast_length.h
> b/generic/include/clc/geometric/fast_length.h
> new file mode 100644
> index 0000000..2c7b80a
> --- /dev/null
> +++ b/generic/include/clc/geometric/fast_length.h
> @@ -0,0 +1,24 @@
> +/*
> + * Copyright (c) 2014,2015 Advanced Micro Devices, Inc.
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining
> a copy
> + * of this software and associated documentation files (the "Software"),
> to deal
> + * in the Software without restriction, including without limitation the
> rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or
> sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> IN
> + * THE SOFTWARE.
> + */
> +
> +#define __CLC_BODY <clc/geometric/fast_length.inc>
> +#include <clc/geometric/floatn.inc>
> diff --git a/generic/include/clc/geometric/fast_length.inc
> b/generic/include/clc/geometric/fast_length.inc
> new file mode 100644
> index 0000000..5a7c275
> --- /dev/null
> +++ b/generic/include/clc/geometric/fast_length.inc
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright (c) 2014,2015 Advanced Micro Devices, Inc.
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining
> a copy
> + * of this software and associated documentation files (the "Software"),
> to deal
> + * in the Software without restriction, including without limitation the
> rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or
> sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> IN
> + * THE SOFTWARE.
> + */
> +
> +_CLC_OVERLOAD _CLC_DECL __CLC_FLOAT fast_length(__CLC_FLOATN p0);
> diff --git a/generic/lib/SOURCES b/generic/lib/SOURCES
> index fb56135..02a05e4 100644
> --- a/generic/lib/SOURCES
> +++ b/generic/lib/SOURCES
> @@ -35,6 +35,7 @@ common/step.cl
>  geometric/cross.cl
>  geometric/distance.cl
>  geometric/dot.cl
> +geometric/fast_length.cl
>  geometric/length.cl
>  geometric/normalize.cl
>  integer/abs.cl
> diff --git a/generic/lib/geometric/fast_length.cl b/generic/lib/geometric/
> fast_length.cl
> new file mode 100644
> index 0000000..425dcf7
> --- /dev/null
> +++ b/generic/lib/geometric/fast_length.cl
> @@ -0,0 +1,60 @@
> +/*
> + * Copyright (c) 2014 Advanced Micro Devices, Inc.
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining
> a copy
> + * of this software and associated documentation files (the "Software"),
> to deal
> + * in the Software without restriction, including without limitation the
> rights
> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or
> sell
> + * copies of the Software, and to permit persons to whom the Software is
> + * furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice shall be
> included in
> + * all copies or substantial portions of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> SHALL THE
> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> ARISING FROM,
> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> IN
> + * THE SOFTWARE.
> + */
> +
> +#include <clc/clc.h>
> +
> +_CLC_OVERLOAD _CLC_DEF float fast_length(float p) {
> +  return fabs(p);
> +}
> +
> +_CLC_OVERLOAD _CLC_DEF float fast_length(float2 p) {
> +  return half_sqrt(dot(p, p));
> +}
> +
> +_CLC_OVERLOAD _CLC_DEF float fast_length(float3 p) {
> +  return half_sqrt(dot(p, p));
> +}
> +
> +_CLC_OVERLOAD _CLC_DEF float fast_length(float4 p) {
> +  return half_sqrt(dot(p, p));
> +}
> +
> +#ifdef cl_khr_fp64
> +#pragma OPENCL EXTENSION cl_khr_fp64 : enable
> +
> +_CLC_OVERLOAD _CLC_DEF double fast_length(double p) {
> +  return fabs(p);
> +}
> +
> +_CLC_OVERLOAD _CLC_DEF double fast_length(double2 p) {
> +  return half_sqrt(dot(p, p));
> +}
> +
> +_CLC_OVERLOAD _CLC_DEF double fast_length(double3 p) {
> +  return half_sqrt(dot(p, p));
> +}
> +
> +_CLC_OVERLOAD _CLC_DEF double fast_length(double4 p) {
> +  return half_sqrt(dot(p, p));
> +}
> +
> +#endif
> --
> 2.0.4
>
>
> _______________________________________________
> Libclc-dev mailing list
> Libclc-dev at pcc.me.uk
> http://www.pcc.me.uk/cgi-bin/mailman/listinfo/libclc-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/libclc-dev/attachments/20150312/c97464fe/attachment.html>


More information about the Libclc-dev mailing list