[Libclc-dev] [PATCH 2/3] Implement degrees builtin

Tom Stellard tom at stellard.net
Thu Feb 26 09:07:56 PST 2015 

On Wed, Feb 25, 2015 at 08:34:07PM -0600, Aaron Watry wrote:
> On Wed, Feb 25, 2015 at 6:28 PM, Matt Arsenault <Matthew.Arsenault at amd.com>
> wrote:
> 
> >  On 02/25/2015 04:24 PM, Aaron Watry wrote:
> >
> >  Looks good to me.
> >
> >  Do we have a test case for this somewhere?
> >
> >  --Aaron
> >
> >  Things like this are the main thing the OpenCL conformance tests are
> > good at
> >
> >
> Yeah, that's something that I don't have access to...  I'll assume that
> someone's been running this against the conformance tests and that the
> tests pass.
> 
> It just helps to note (and builds confidence in correctness) that new
> built-in implementations have been tested against piglit, opencv, the CL
> conformance tests, webcl conformance, etc. just to note that the
> implementation has been tested on something other than the local dev's
> machine.
>

I usually test against piglit, OpenCV, and a subset of the conformance
tests before I send patches.  I can add a note in the commit message
that these tests pass conformance.

-Tom

> --Aaron
> 
> >
> >  On Tue, Feb 24, 2015 at 2:15 PM, Tom Stellard <thomas.stellard at amd.com>
> > wrote:
> >
> >> ---
> >>  generic/include/clc/clc.h                 |  1 +
> >>  generic/include/clc/geometric/degrees.h   | 24 +++++++++++++++++
> >>  generic/include/clc/geometric/degrees.inc | 23 ++++++++++++++++
> >>  generic/lib/SOURCES                       |  1 +
> >>  generic/lib/geometric/degrees.cl          | 45
> >> +++++++++++++++++++++++++++++++
> >>  5 files changed, 94 insertions(+)
> >>  create mode 100644 generic/include/clc/geometric/degrees.h
> >>  create mode 100644 generic/include/clc/geometric/degrees.inc
> >>  create mode 100644 generic/lib/geometric/degrees.cl
> >>
> >> diff --git a/generic/include/clc/clc.h b/generic/include/clc/clc.h
> >> index bd92fdb..02ecc1c 100644
> >> --- a/generic/include/clc/clc.h
> >> +++ b/generic/include/clc/clc.h
> >> @@ -110,6 +110,7 @@
> >>
> >>  /* 6.11.5 Geometric Functions */
> >>  #include <clc/geometric/cross.h>
> >> +#include <clc/geometric/degrees.h>
> >>  #include <clc/geometric/dot.h>
> >>  #include <clc/geometric/length.h>
> >>  #include <clc/geometric/normalize.h>
> >> diff --git a/generic/include/clc/geometric/degrees.h
> >> b/generic/include/clc/geometric/degrees.h
> >> new file mode 100644
> >> index 0000000..dfccdd3
> >> --- /dev/null
> >> +++ b/generic/include/clc/geometric/degrees.h
> >> @@ -0,0 +1,24 @@
> >> +/*
> >> + * Copyright (c) 2014,2015 Advanced Micro Devices, Inc.
> >> + *
> >> + * Permission is hereby granted, free of charge, to any person obtaining
> >> a copy
> >> + * of this software and associated documentation files (the "Software"),
> >> to deal
> >> + * in the Software without restriction, including without limitation the
> >> rights
> >> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or
> >> sell
> >> + * copies of the Software, and to permit persons to whom the Software is
> >> + * furnished to do so, subject to the following conditions:
> >> + *
> >> + * The above copyright notice and this permission notice shall be
> >> included in
> >> + * all copies or substantial portions of the Software.
> >> + *
> >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> >> EXPRESS OR
> >> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> >> MERCHANTABILITY,
> >> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> >> SHALL THE
> >> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> >> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> >> ARISING FROM,
> >> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> >> DEALINGS IN
> >> + * THE SOFTWARE.
> >> + */
> >> +
> >> +#define __CLC_BODY <clc/geometric/degrees.inc>
> >> +#include <clc/geometric/floatn.inc>
> >> diff --git a/generic/include/clc/geometric/degrees.inc
> >> b/generic/include/clc/geometric/degrees.inc
> >> new file mode 100644
> >> index 0000000..c4b2247
> >> --- /dev/null
> >> +++ b/generic/include/clc/geometric/degrees.inc
> >> @@ -0,0 +1,23 @@
> >> +/*
> >> + * Copyright (c) 2014,2015 Advanced Micro Devices, Inc.
> >> + *
> >> + * Permission is hereby granted, free of charge, to any person obtaining
> >> a copy
> >> + * of this software and associated documentation files (the "Software"),
> >> to deal
> >> + * in the Software without restriction, including without limitation the
> >> rights
> >> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or
> >> sell
> >> + * copies of the Software, and to permit persons to whom the Software is
> >> + * furnished to do so, subject to the following conditions:
> >> + *
> >> + * The above copyright notice and this permission notice shall be
> >> included in
> >> + * all copies or substantial portions of the Software.
> >> + *
> >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> >> EXPRESS OR
> >> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> >> MERCHANTABILITY,
> >> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> >> SHALL THE
> >> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> >> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> >> ARISING FROM,
> >> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> >> DEALINGS IN
> >> + * THE SOFTWARE.
> >> + */
> >> +
> >> +_CLC_OVERLOAD _CLC_DECL __CLC_FLOATN degrees(__CLC_FLOATN x);
> >> diff --git a/generic/lib/SOURCES b/generic/lib/SOURCES
> >> index b76fec9..fd90781 100644
> >> --- a/generic/lib/SOURCES
> >> +++ b/generic/lib/SOURCES
> >> @@ -29,6 +29,7 @@ cl_khr_local_int32_extended_atomics/atom_xor.cl
> >>  convert.cl
> >>  common/sign.cl
> >>  geometric/cross.cl
> >> +geometric/degrees.cl
> >>  geometric/dot.cl
> >>  geometric/length.cl
> >>  geometric/normalize.cl
> >> diff --git a/generic/lib/geometric/degrees.cl b/generic/lib/geometric/
> >> degrees.cl
> >> new file mode 100644
> >> index 0000000..5de56f8
> >> --- /dev/null
> >> +++ b/generic/lib/geometric/degrees.cl
> >> @@ -0,0 +1,45 @@
> >> +/*
> >> + * Copyright (c) 2014,2015 Advanced Micro Devices, Inc.
> >> + *
> >> + * Permission is hereby granted, free of charge, to any person obtaining
> >> a copy
> >> + * of this software and associated documentation files (the "Software"),
> >> to deal
> >> + * in the Software without restriction, including without limitation the
> >> rights
> >> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or
> >> sell
> >> + * copies of the Software, and to permit persons to whom the Software is
> >> + * furnished to do so, subject to the following conditions:
> >> + *
> >> + * The above copyright notice and this permission notice shall be
> >> included in
> >> + * all copies or substantial portions of the Software.
> >> + *
> >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> >> EXPRESS OR
> >> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> >> MERCHANTABILITY,
> >> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT
> >> SHALL THE
> >> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> >> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> >> ARISING FROM,
> >> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> >> DEALINGS IN
> >> + * THE SOFTWARE.
> >> + */
> >> +
> >> +#include <clc/clc.h>
> >> +
> >> +#include "../clcmacro.h"
> >> +
> >> +_CLC_OVERLOAD _CLC_DEF float degrees(float radians) {
> >> +  // 180/pi = ~57.29577951308232087685 or 0x1.ca5dc1a63c1f8p+5 or
> >> 0x1.ca5dc2p+5F
> >> +  return 0x1.ca5dc2p+5F * radians;
> >> +}
> >> +
> >> +_CLC_UNARY_VECTORIZE(_CLC_OVERLOAD _CLC_DEF, float, degrees, float);
> >> +
> >> +
> >> +#ifdef cl_khr_fp64
> >> +#pragma OPENCL EXTENSION cl_khr_fp64 : enable
> >> +
> >> +_CLC_OVERLOAD _CLC_DEF double degrees(double radians) {
> >> +  // 180/pi = ~57.29577951308232087685 or 0x1.ca5dc1a63c1f8p+5 or
> >> 0x1.ca5dc2p+5F
> >> +  return 0x1.ca5dc1a63c1f8p+5 * radians;
> >> +}
> >> +
> >> +_CLC_UNARY_VECTORIZE(_CLC_OVERLOAD _CLC_DEF, double, degrees, double);
> >> +
> >> +#endif
> >> --
> >> 2.0.4
> >>
> >>
> >> _______________________________________________
> >> Libclc-dev mailing list
> >> Libclc-dev at pcc.me.uk
> >> http://www.pcc.me.uk/cgi-bin/mailman/listinfo/libclc-dev
> >>
> >
> >
> >
> > _______________________________________________
> > Libclc-dev mailing listLibclc-dev at pcc.me.ukhttp://www.pcc.me.uk/cgi-bin/mailman/listinfo/libclc-dev
> >
> >
> >

> _______________________________________________
> Libclc-dev mailing list
> Libclc-dev at pcc.me.uk
> http://www.pcc.me.uk/cgi-bin/mailman/listinfo/libclc-dev

More information about the Libclc-dev mailing list