<div dir="ltr">I'm curious what's taking so long. What's the change in code generation in the functions with and without the asan instrumentation?<div><br></div><div>-eric</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 5, 2020 at 1:37 PM Siva Chandra via libc-commits <<a href="mailto:libc-commits@lists.llvm.org">libc-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">I submitted this without review to unblock the asan bot. Feel free to suggest other ways to improve the run time.</div><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, May 5, 2020 at 1:31 PM Siva Chandra Reddy via libc-commits <<a href="mailto:libc-commits@lists.llvm.org" target="_blank">libc-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
Author: Siva Chandra Reddy<br>
Date: 2020-05-05T13:30:30-07:00<br>
New Revision: fbaaa16802d7b2fc096c8ed5fa23e0cad56807a2<br>
<br>
URL: <a href="https://github.com/llvm/llvm-project/commit/fbaaa16802d7b2fc096c8ed5fa23e0cad56807a2" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/fbaaa16802d7b2fc096c8ed5fa23e0cad56807a2</a><br>
DIFF: <a href="https://github.com/llvm/llvm-project/commit/fbaaa16802d7b2fc096c8ed5fa23e0cad56807a2.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/fbaaa16802d7b2fc096c8ed5fa23e0cad56807a2.diff</a><br>
<br>
LOG: [libc] Add no_sanitize("address") attribute to the getMPFRMatcher function.<br>
<br>
This dramtically reduces the run time of tests. For example,<br>
sincosf_test takes over 25 minutes without this attribute but only 8<br>
seconds with this attribute.<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
    libc/utils/MPFRWrapper/MPFRUtils.h<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff  --git a/libc/utils/MPFRWrapper/MPFRUtils.h b/libc/utils/MPFRWrapper/MPFRUtils.h<br>
index 31afd39b2895..6cdba34882d5 100644<br>
--- a/libc/utils/MPFRWrapper/MPFRUtils.h<br>
+++ b/libc/utils/MPFRWrapper/MPFRUtils.h<br>
@@ -73,6 +73,7 @@ template <typename T> class MPFRMatcher : public testing::Matcher<T> {<br>
 } // namespace internal<br>
<br>
 template <typename T><br>
+__attribute__((no_sanitize("address")))<br>
 internal::MPFRMatcher<T> getMPFRMatcher(Operation op, T input, Tolerance t) {<br>
   static_assert(<br>
       __llvm_libc::cpp::IsFloatingPointType<T>::Value,<br>
<br>
<br>
<br>
_______________________________________________<br>
libc-commits mailing list<br>
<a href="mailto:libc-commits@lists.llvm.org" target="_blank">libc-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/libc-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/libc-commits</a><br>
</blockquote></div>
_______________________________________________<br>
libc-commits mailing list<br>
<a href="mailto:libc-commits@lists.llvm.org" target="_blank">libc-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/libc-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/libc-commits</a><br>
</blockquote></div>