[libc-commits] [libc] [llvm] [libc] Remove direct math.h includes (PR #85324)

Benjamin Kramer via libc-commits libc-commits at lists.llvm.org
Tue Mar 19 09:48:01 PDT 2024


================
@@ -62,7 +62,17 @@ config_setting(
     flag_values = {":mpfr": "system"},
 )
 
-############################## Support libraries #############################
+################################# Include Files ################################
+
+libc_support_library(
+    name = "internal_includes",
----------------
d0k wrote:

I don't understand why all the other internal headers are factored into sublibraries but this one is not. It also overlaps with other libraries, which isn't will cause the build to turn messier over time as tooling no longer works.

The libc BUILD is very high maintenance and I thought there was a reason why it's set up that way. If it actually doesn't matter why not glob more things into one library and save a lot of work?

https://github.com/llvm/llvm-project/pull/85324


More information about the libc-commits mailing list