[libc-commits] [libc] [llvm] [RFC][libc] Codify header inclusion policy (PR #87017)

Nick Desaulniers via libc-commits libc-commits at lists.llvm.org
Thu Apr 11 08:41:35 PDT 2024


================
@@ -9,18 +9,15 @@
 #ifndef LLVM_LIBC_SRC_SYS_EPOLL_EPOLL_PWAIT2_H
 #define LLVM_LIBC_SRC_SYS_EPOLL_EPOLL_PWAIT2_H
 
-// TODO: Use this include once the include headers are also using quotes.
-// #include "include/llvm-libc-types/sigset_t.h"
-// #include "include/llvm-libc-types/struct_epoll_event.h"
-// #include "include/llvm-libc-types/struct_timespec.h"
-
-#include <sys/epoll.h>
+#include "hdr/types/sigset_t.h"
+#include "hdr/types/struct_epoll_event.h"
+#include "hdr/types/struct_timespec.h"
 
 namespace LIBC_NAMESPACE {
 
 // TODO: sigmask and timeout should be nullable
-int epoll_pwait2(int epfd, epoll_event *events, int maxevents,
-                 const timespec *timeout, const sigset_t *sigmask);
+int epoll_pwait2(int epfd, struct epoll_event *events, int maxevents,
----------------
nickdesaulniers wrote:

ah, sorry, I was abused as a C programmer. Reminders these keywords are no longer necessary in C++ mode are helpful. 6eb84ea293d7

https://github.com/llvm/llvm-project/pull/87017


More information about the libc-commits mailing list