[libc-commits] [PATCH] D158774: [libc] Add GPU support for `printf` and `fprintf`

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Sep 6 16:44:45 PDT 2023


jhuber6 added inline comments.


================
Comment at: libc/test/integration/startup/gpu/rpc_printf_test.cpp:72
+
+  return 0;
+}
----------------
michaelrj wrote:
> is it possible to re-open the file in read mode at the end to check that the output strings are what is expected?
It's a little annoying here because I need to test this stuff with multiple threads. Meaning that everything's in a random order.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158774/new/

https://reviews.llvm.org/D158774



More information about the libc-commits mailing list