[libc-commits] [PATCH] D150309: [libc][rpc] Allocate locks array within process
Joseph Huber via Phabricator via libc-commits
libc-commits at lists.llvm.org
Wed May 10 14:37:14 PDT 2023
jhuber6 added inline comments.
================
Comment at: libc/src/__support/RPC/rpc.h:107
+ enum { maximum_port_count = 128 };
+
----------------
JonChesterfield wrote:
> Number doesn't matter hugely at this point, have gone with deliberately != default_port_count.
What's the point of keeping both around?
================
Comment at: libc/utils/gpu/loader/amdgpu/Loader.cpp:362
// Initialize the RPC server's buffer for host-device communication.
- server.reset(port_size, wavefront_size, &lock, server_inbox, server_outbox,
- buffer);
----------------
Needs the same in the nvptx loader.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150309/new/
https://reviews.llvm.org/D150309
More information about the libc-commits
mailing list