[libc-commits] [PATCH] D145913: [libc] Add initial support for an RPC mechanism for the GPU

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: mikhail.ramalho.

I have no major comments so stepping aside.



================
Comment at: libc/src/__support/RPC/rpc.h:1
+//===-- Shared memory RPC client / server interface -------------*- C++ -*-===//
+//
----------------
Should this RPC directory be nested under `OSUtil/gpu` as it is a GPU specific? AFAICT there is nothing GPU specific though.


================
Comment at: libc/src/__support/RPC/rpc.h:39
+enum Opcode : uint64_t {
+  null = 0,
+  print = 1,
----------------
Constants are in `UPPER_CASE` style.


================
Comment at: libc/src/__support/RPC/rpc_client.cpp:22
+/// whomever needs to run the server.
+extern "C" [[gnu::visibility("protected")]] const bool __llvm_libc_rpc = 0;
+
----------------
`false` ? Also, is this being used anywhere?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145913/new/

https://reviews.llvm.org/D145913