[libc-commits] [PATCH] D145444: [libc] Support more functions in riscv

Wed Mar 8 09:43:27 PST 2023

sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.

In D145444#4178442 <https://reviews.llvm.org/D145444#4178442>, @mikhail.ramalho wrote:

> In D145444#4178400 <https://reviews.llvm.org/D145444#4178400>, @sivachandra wrote:
>
>> Hi,
>>
>> Can you separate this out into following patches:
>>
>> 1. Just simple expansion of entrypoints.txt with functions that can now be included without any other changes. Do not include any commented out functions.
>> 2. FMA patch.
>> 3. sqrt patch.
>> 4. Adding riscv `fenv_t` and singal.h macros. Enable full build also with this patch.
>>
>> Thanks,
>> Siva Chandra
>
> No problem!
>
> I only left the commented sin, cos and tan, if that's alright.

I see more functions commented out. Commenting out is fine as long as we include a good reason why it has been commented out.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145444/new/

https://reviews.llvm.org/D145444